fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:45 am (UTC)(link)
Hmmmm. Are you using any Greasemonkey scripts? That's... really weird.
highlander_ii: Tony giving peace sign w/ text *peace* ([Iron Man] *peace*)

[personal profile] highlander_ii 2012-09-23 05:46 am (UTC)(link)
just the DW post expand/collapse one... which could be doing it, as, both of those posts had been collapsed.

... and the expand/collapse icons are on that page and they work... so, that's probably it.... (just tested that)
Edited 2012-09-23 05:47 (UTC)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:48 am (UTC)(link)
Hm. Can you turn it off and test or look in another browser?
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:49 am (UTC)(link)
Aha! Okay :) Yeah, the Greasemonkey script must be looking for something in the CSS, and refreshes on page-load
highlander_ii: Josh Duhamel's hip; his hand in his pocket ([Josh D] hand inna pocket)

[personal profile] highlander_ii 2012-09-23 05:50 am (UTC)(link)
probably so... Chrome didn't do that (doesn't have that extension)...

momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:56 am (UTC)(link)
Okay, sounds like a Greasemonkey problem then, unfortunately :\ Might be worth reporting to the script author?