fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

cheyinka: A glowing blue sheep with green eyes (electric sheep)

tracking comments

[personal profile] cheyinka 2012-10-05 10:18 pm (UTC)(link)
Fairly certain this is just Chrome being weird (possibly just Chrome in Windows, I can switch into FreeBSD and check), because it works fine in Firefox in Windows but:
Previously, I could middle-click the bell icon and go directly to the more-options page for tracking; now middle-clicking just causes the same popup as left-clicking.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

Re: tracking comments

[staff profile] denise 2012-10-05 10:28 pm (UTC)(link)
That usually means the browser's prevented the JS from loading -- are you having problems with the javascript site-wide? Check your security settings and make sure you haven't blocked scripting from us.
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-05 11:48 pm (UTC)(link)
I haven't blocked scripting, and I haven't noticed any other issues - answering a poll still works, for example. The more options link in the tracking popup works, too - it's just that middle-clicking the link doesn't open the more options page in a new tab the way it does in Firefox or the way it used to in Chrome.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: tracking comments

[personal profile] momijizukamori 2012-10-07 06:37 am (UTC)(link)
It does sound like it may be Chrome weirdness, possibly with regard to keyboard/mouse short-cuts (as middle-click is just a shortcut to 'Open link in new tab'). Does right-click -> open link in new tab work?
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-07 05:55 pm (UTC)(link)
Yep, right-click then open link works fine!
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

Re: tracking comments

[personal profile] momijizukamori 2012-10-08 04:23 am (UTC)(link)
Yeah, in that case it sounds like Chrome changed something with how they register on-click events in Javascript :\
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-08 09:19 pm (UTC)(link)
It is just the new comment pages; new comment pages off with beta JS on still works, but new comment pages on with beta JS off doesn't work. (Well, it works except for this one tiny thing! Otherwise, the new pages look extremely similar and the one difference I notice is (in my opinion) an improvement.)

[Edit, 2012-10-10: Same behavior in Chrome (well, "chromium") in FreeBSD; still works in Firefox in FreeBSD.]
Edited (may as well just edit the comment) 2012-10-10 18:31 (UTC)