fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

boomvox: (Default)

[personal profile] boomvox 2012-12-03 07:38 pm (UTC)(link)
I've noticed you moved the private/locked icon from up in the time/date info back down to the subject line area! It still doesn't look quite like the non-beta comment page though; it's squished right against the subject line and is uneven and a bit cramped looking. On the non-s2 I think the private/locked icon is actually on its own line above the subject?

It's much easier to see this way but it's still a bit cramped up there with the tags, privacy level icon, and subject line all crammed into the same area.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-12-03 07:40 pm (UTC)(link)
Yeah, that was an intentional change, though still somewhat up for debate - people were leaning in favor of keeping it inline with the subject rather than the old version of having it above the subject, but it's not a hard and fast final decision if a larger sample size indicates it's not working out (I generally poll the IRC channels on stuff when I'm working on design tweaks)
boomvox: (Default)

[personal profile] boomvox 2012-12-03 07:45 pm (UTC)(link)
It's definitely better than what it was before, and I wouldn't be irritated if it was kept as-is. Despite it looking a bit cramped/cluttered it's clearer for what it is than previous versions!

Obviously I'm not in that IRC channel, but I just.. like leaving feedback, apparently. >_>
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-12-03 07:48 pm (UTC)(link)
Haha, yeah, no, feedback is good! I more meant that when I'm in the working-on-stuff stage it just gets limited feedback from IRC (because it's quick to show stuff off to people there), which means I don't get wider feedback until it goes live :)
melannen: Commander Valentine of Alpha Squad Seven, a red-haired female Nick Fury in space, smoking contemplatively (Default)

[personal profile] melannen 2013-01-29 05:52 am (UTC)(link)
When I'm in a collapsed comment thread (in sitescheme tropo red), and I expand a few comments at the end of a thread but not the whole thread, and open a reply box on one of them, and then decide I want to re-read more of the thread before I reply, so I click expand on a comment farther up the thread, the reply box I had open disappears, and then I can no longer open a reply box anywhere in the comments until I reload the whole page.

This happens with both the new js and the new comment page betas ON; if I turn either of them OFF, it stops happening (my reply box stays open even after I expand farther up the thread, and I can open one in a different place if I want to.)

I've no idea when it started happening, I only noticed it tonight. It's happening in Opera 12 and in Firefox 16, in Windows XP and Windows 8. (I tried IE6 and IE10 too but the javascript in-page comment expand doesn't seem to work at all in IE, so that gave no new data.)
murkrows: (Default)

[personal profile] murkrows 2013-04-14 08:29 pm (UTC)(link)
Hi! I know this is pretty late, but here goes. I'm on a Mac right now, and after updating to the latest OS (OSX 10.8.3) I've noticed that Dreamwidth's S2 commenting is taking a lot longer to load, and frequently crashes with an error message. Sometimes on a comment page, the comments simply don't load at all, and I have to refresh the whole page if I want to see anything more than the origin journal entry. On 10.6, I never had this problem at all, even with the S2 commenting. Dreamwidth works fine on Lynx, though, which is what I'm using now. If possible, would someone at DW please look into this? Thank you guys, I really appreciate everything you've done. <3

EDIT: Ah, sorry, spoke too soon. Looks like it still happens on Lynx. :c So maybe it's something else? I'm not sure...
Edited 2013-04-14 20:44 (UTC)

Page 2 of 2

<< [1] [2] >>