fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

yrbirdcanscene: blonde in a coat from a dior ad (dior coat)

[personal profile] yrbirdcanscene 2012-09-23 11:23 pm (UTC)(link)
I have to agree with all of this. I've tried it in Chrome, Firefox, and RockMelt, both with my Grease/Tamper Monkey and Stylish scripts on and off, and I find the linked titles to be ugly, quite frankly. The link is redundant, as there are multiple ways to access a comment link already.

Additionally, I like to comment from my smartphone, and don't like the mobile interface (which is neither here nor there), so I use the regular site, as it displays just fine. But with the comment titles made links, that's just one more thing I can accidentally click on while I'm just trying to scroll through the page.

Essentially, I don't think there was anything wrong with the previous comment title format (i.e. non-linked), and would be thrilled if it did not change.
boomvox: (pic#2886153)

[personal profile] boomvox 2012-09-23 11:29 pm (UTC)(link)
+1 to all of this, especially the mobile issue which I didn't even think of at first. I use the normal page through my smartphone's browser too, which is actually a lot easier than the mobile interface and just fine. But links in comment subjects are going to make scrolling and trying to click on anything else a real crap shoot.
momijizukamori: Young Vergil from the Devil May Cry doujinshi Bless. The text reads 'Turn you into stars' (kid!Vergil | turn you into stars)

[personal profile] momijizukamori 2012-09-24 07:16 pm (UTC)(link)
They've been changed! And thankfully the mobile interface should be getting a redesign to haul it into the 21st century soon (though that's not my project)
boomvox: (pic#3208725)

[personal profile] boomvox 2012-09-24 07:37 pm (UTC)(link)
Hooray to both of those things!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Science! | I do believe in phosphorylati)

[personal profile] momijizukamori 2012-09-24 07:08 pm (UTC)(link)
It's actually not a change from S2 - all journal styles have linked comment titles - but based on feedback we went ahead and changed it to mimic the BML style, so you should have happily unlinked comments now :)