New JS on Journals: Last Call

[fu]

We're planning on taking the "new JavaScript on journals" changes out of beta soon and making the changes the default for the entire site, so we've done a push today that adds the last few (reported) missing features, and fixes the last few (reported) really annoying behaviors.

There's always going to be one thing more though, so please make sure that you turn on beta for the new JS on journals, and tell us how that new JS works for you -- or doesn't work, if that's the case.

I'm interested in hearing about everything that's bothering you, no matter how tiny it seems! The sooner we know, the sooner we can fix it. (Just this code push, we fixed two things that seemed tiny: one was the hover menu fading way too quickly, another was how the attempt to change your poll vote would bring to you to a separate page instead of changing your vote on the page you were on. They were both things we missed at first, but once they were brought to our attention, we couldn't stop seeing them. And now they're fixed!)

So poke around, and let us know what you find. If you're looking for something to focus on, here's a short list of things we recently added or fixed:

• added same-page comment tracking


• fixed same-page changing of poll votes


• added displaying errors when comment expansion fails to work


• fixed hover menu fading away even when you didn't move your mouse


• fixed the .cuttag-open CSS class so it applies to the contents of the opened cut tag (the way the old JS did), for people who want to customize this in their styles


• made the bottom arrow jump you to the top of the cut tag, without affecting page forward/back

Assuming there are no major issues, we'll turn on the "new JS on journals" beta flag for everyone with our next code push for one last round of testing with the whole site, not just the people who've turned on the beta version. We'll keep it as a beta option at that point, so if anyone has serious problems, they can disable the beta and go back to the old JS while we fix the problem. After that, we'll take this code out of beta and make it the standard option for everyone, removing the old (existing) JavaScript entirely. So, if something's wrong, speak up now!

Comments

[denise]

eyesofstrength, below, was having a similar problem and narrowed it down to three extensions (tab counter, tab mix plus and tabs menu) -- do you have any of those installed? If not, can you try the exclusion method I described in this comment and see if you can narrow down which extensions are causing the problem?

[pocketmouse]

I was getting a jquery error (which I screencapped, if you want it). Firefox 11, Mac 10.5.8. I have Tab Mix Plus, so I disabled that and restarted, but then it threw errors at me from other addons, specifying the addons this time, specifically for DoNotTrackPlus and HTTPS-Everywhere. With those two disabled but Tab Mix Plus on, it works, if a bit slow. If I turn one of them on, it throws a jquery error at me, not an add-on error.

ETA: And then it did it again, this time telling me there was an error in ghostery. Basically, it's not happy with any of my security addons.

[denise]

Huh. Yes please, seeing errors is always helpful!

[pocketmouse]

JQuery error (it was the same one every time)

Various addon errors.

None of the listed errors are for Tab Mix Plus, so I really don't think it's related.

[fu]

Thanks! I'm currently trying to figure out how to optimize this. Do you happen to notice if the slowness affects just site-skinned comment pages, or if it affects custom comment pages as well?

[pocketmouse]

Nope, sorry. I could try and find some custom comment pages with enough entries to expand, but it wouldn't be til this evening.

[funkybrewsta]

I have neither of those add-ons, though I do have IE Tab and ColorfulTabs which I turned off only to get MORE errors from Chrome (I don't know why when I am using Firefox) and Ghostery and ooh boy. Like Pocketmouse said, it seems unhappy with anything.

[fu]

Do you recall what errors you were getting? Were they unresponsive script errors?