fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am
  • Add Memory
  • Share This Entry

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

Flat | Top-Level Comments Only
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 06:15 am (UTC)(link)
They should! Can you give me a screencap? (I'm also using Tropo Red and seeing them linked)
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2012-09-23 11:58 am (UTC)(link)
Same here with Tropo Purple and in both Chromium and Iceweasel.

Beta is turned on and the divs are there instead of the tables.

EDIT: Or should there be no tables at all? Maybe I am not getting the S2 pages after all...

More EDIT: like the one persona above, with style=site I get the new style, but without, I am seeing the old one.

http://imgur.com/DV8XD

Edited 2012-09-23 12:01 (UTC)
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[personal profile] fu 2012-09-23 01:27 pm (UTC)(link)
Ooops. I'm collecting ponies it seems -- fixed!
Flat | Top-Level Comments Only