fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

boomvox: (pic#2863491)

[personal profile] boomvox 2012-09-23 07:32 pm (UTC)(link)
I'm turning it on and off as I mess with it overlaid with a greasemonkey script (turned off for now to look at this), and I've noticed that when comments are collapsed, all the links to the collapsed comments are bolded, when they aren't without the beta turned on.

I'd also like to echo that the bold/underline link on subject lines is aesthetically unpleasing and distracting. It makes me think there's a borked tag in the post body I need to go fix, and it looks really clunky.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 09:20 pm (UTC)(link)
The collapsed comment thing is noted! I'll get that added to my list :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 10:45 pm (UTC)(link)
Collapsed comments should now be fixed!
boomvox: (pic#3208725)

[personal profile] boomvox 2012-09-23 10:52 pm (UTC)(link)
Yep, looks fixed from here! :)
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-09-23 11:37 pm (UTC)(link)
Oh, thank you for that. It was very distracting to have those bolded. Much, much nicer now.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 11:40 pm (UTC)(link)
All hail the power of git, which lets us roll fixes to live quickly *g*