Comment Pages in S2: the old becomes new

[fu]

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. exor674 worked hard on the backend to make this possible, then momijizukamori came through with some spit and polish (with some help from kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

Comments

[axiom_of_stripe]

In Celerity, the entry title has shrunk from h2 to h3 and there's now a line between the poster info and the action box. The title change isn't a huge problem (although I do like it larger) but the line is a bit disorienting. If there's a dividing line wanted, it would make much more sense to me to have it instead between the actions and the title + content, but I'm not sure why it's wanted.

(Chrome on Vista; I can screenshot if this is an error instead of a choice!)

[momijizukamori]

Can you screencap the line for me? And I'll make a not of the font-size thing and check it across the other site schemes - that one is an easy enough fix :)

[axiom_of_stripe]

Here is it:

http://ic.pics.livejournal.com/cmshaw/392463/199772/199772_original.png

Thanks! :)

[momijizukamori]

Ooh, naughty Celerity, adding an extra border in there. I'll get that taken care of.

[momijizukamori]

Got the problems with Celerity fixed :)

[axiom_of_stripe]

\o/ This is an awesome project, by the way. :)

[momijizukamori]

font-size on titles should be what it used to be now!