fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

turlough: Gabe Saporta doing thumbs-up ((cs) gabe approves)

[personal profile] turlough 2012-09-24 07:14 pm (UTC)(link)
Looks good now!
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-09-24 07:18 pm (UTC)(link)
Appropriate icon is appropriate *g*
turlough: on the bridge of the Swinetrek, Pigs in Space on The Muppet Show ((muppets) pigs in spaaace!)

[personal profile] turlough 2012-09-24 07:47 pm (UTC)(link)
Btw, in .comment-info I would suggest letting .poster display inline instead of block. That way you get rid of the irritating strip of grey under the icon and the datetime + permalink + management-links combo moves up beside .poster instead of being squished under it. (Looks like this now and with the suggested change like this.)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 07:51 pm (UTC)(link)
The problem there is actually that Lynx doesn't strip the massive amount of padding that header tags have on them :\ It's certainly a possibility, but it's more a departure from the BML look, and I'm afraid it'll cause messy-looking line-breaks sooner (as that line is now longer)
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2012-09-24 07:53 pm (UTC)(link)
It is ok to recode the Lynx site skin. I believe it was written in 1998. :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 07:54 pm (UTC)(link)
Ahh, I might add that reset to it then :)

(and omg ANCIENT CODE)
turlough: snickering white cat, Duchess from Disney's 'Aristocats' ((disney) fun)

[personal profile] turlough 2012-09-24 08:00 pm (UTC)(link)
That just means it's a classic :-)
momijizukamori: (dreamsheep | styles)

[personal profile] momijizukamori 2012-09-24 08:02 pm (UTC)(link)
Lynx = the hipster userscheme? All 20th century up in here ;)?
turlough: the Doctor & Harry & Sarah-Jane in Bessie, promo photo for season 12 ((dr who) companions)

[personal profile] turlough 2012-09-24 07:59 pm (UTC)(link)
Silly Lynx!