Javascript on Journals: last call ( I mean it this time! )

[fu]

The last code push included some small and not-so-small fixes to the javascript on journals beta. The biggest visible change is that various items have a completely different look -- this includes dialog boxes on your journal when you try to track comments, and the contextualhover menu. Further details are in my entry to dw-styles (Upcoming changes to contextual hover menu styling (beta) ).

I believe that all the worst bugs for javascript on journals have been reported and fixed. Soon we plan to switch everyone over to the new version, with the ability to opt-out in case any annoying bugs are found once it's had more eyes on it. We'll post about it when that happens.

Please continue to let us know in the comments if you run into any issues, so we can fix them ASAP!

Comments

[ninetydegrees]

Love the new looks! So clean! Noticed that non-square icons get distorted in pop-ups, though.

[fu]

Oops, should be better now!

[ninetydegrees]

Brilliant! Thank you!

[cheyinka]

Is this the place to report something that still doesn't work (the way I'd expect), or just for new-with-these changes issues?

[fu]

Best place would be support, but ask here anyway!

comment tracking popups

[cheyinka]

It's the same as what I reported on the s2 comment pages entry (http://dw-beta.dreamwidth.org/13187.html?thread=330115#cmt330115), that in Chrome in Windows or Chromium in FreeBSD, middle-clicking the track this icon doesn't open the more options page in a new tab like it used to in Chrome/ium or still does in Firefox.

Re: comment tracking popups

[fu]

Ask and you shall receive! (if you're on the journal JS beta)

Does that work now? It should. Let me know if it still doesn't.

Re: comment tracking popups

[cheyinka]

EEEEEEEEEeeeeeeeeeeeeeeeeeeee yes it works now. (Sorry about any hearing damage from my shriek of glee.)

Re: comment tracking popups

[fu]

It is my pleasure! Thank you for pointing that out in the first place.

[runpunkrun]

Okay, so, on site-scheme pages the contextual hover menus look different and have the bigger fonts, as advertised, but on my reading and journal pages the FONT IS ENORMOUS and the box is easily twice as big.

[fu]

Yes! It's meant to match the general font on the page (the font on site skin is slightly smaller than we usually have for journal pages which is why the difference).

You can adjust it on your journal, though, by putting the following into the embedded css text area:

.ContextualPopup { font-size: 0.85em; }

That should get everything roughly to the previous size.

[runpunkrun]

Brilliant! Thank you!

[ninetydegrees]

I've just realized some of the CSS used in styles to customize pop-ups no longer works. Although we might want to limit what kind of styling's being applied there it was useful to keep it light on dark for example. Haven't looked at the new CSS structure yet so this might just be a consequence of that. Just wanted to mention before I forgot. ;)

Edit: yeah it's just a CSS thing. I'll open a bug for it.

[fu]

Yes! http://bugs.dwscoalition.org/show_bug.cgi?id=4782 (I got partway through looking at the problem, but wasn't able to actually do anything before code push)

[ninetydegrees]

Oh missed that. Grabbed it then. Thanks!

[fu]

Oh man you are awesome. Thank you for taking a look at that!

[truth_is_cold]

If I'm using the mercury browser when I use my Ipad and it uses the default settings for the javascript journal creation, where usually I have a sidebar and other journal options available to use.

[eyesofstrength]

I've been noticing something when you go through and use the hide comments option on a thread. Normally the first time it works fine. But if you go and hide the comments on a lower thread a good amount of the time the page scrolls up to the first thread I hid comments on. Yeah, I can scroll back down of course, but that just gets rather frustrating when trying to quickly go through and hide and expand stuff.

Love the new hover menus though. I can finally read them!

[fu]

Glad the new hover menus work for you!

I'm trying to duplicate as you described, but I'm not seeing anything out of place, so I need more info. Can you let me know your browser please? A link to somewhere you run into this might also provide a clue.

[eyesofstrength]

Sorry for the late response. I have Firefox 5.0.1. Windows 7, Add ons are adblock plus, noscript (which has DW allowed), greasemonkey, ljlogin, screengrab, stop autoplay, stylish, tab counter, tab mix plus, and tabs menu.

One page where it happens a lot is here: http://luceti.dreamwidth.org/5691.html?page=21#comments

Basically I go through the apps there to enter them into the game's spreadsheet. As I finish one, I like to hide the comments so I know it's done and expand the ones that aren't done.

One time I did notice that the link changed acting like I had commented there when I hadn't, but the more recent time it did not. But to give an idea of what happened here's a more specific instance. I went to hide the comments in this thread since the player never responded on revisions. When I did so, it scrolled up to a point in this thread. I hadn't actually linked the threads, that is more to give an idea of where I was and where it went to on that page. It tends to do that after I have hid comments on at least one thread and the location varies, just tends to be around another hidden thread, often about a third of the way down, so this gets more frustrating the further down I get.

[shinbunshinobi]

I have been having trouble deleting my own comments in another's post. I tried both in Firefox and Chrome, but clicking the delete button did nothing. It didn't even bring up a hover menu. Turning off the beta JS testing did let me delete the comment. So, I think there might be something there.

[fu]

Hmmm, the beta JS testing should only be affecting your own journal, not those of the journals you're viewing. Were you viewing the other journal in your style?

Also, would you mind turning on beta again and trying to delete a comment under similar circumstances as before? Then check the error console (probably under the View or Tools menu, might be named Javascript Console or Error Console0

Thanks!

[shinbunshinobi]

I view entries in the site style, and I have it set to view comment pages in my style, which is still the site style.

I turned it back on and did the same thing. This is the comment I'm trying to delete. Nothing happens.

The Javascript Console gave me this:

Uncaught TypeError: Object [object Object] has no method 'uniqueId' www.dreamwidth.org:34
d.widget._create www.dreamwidth.org:34
(anonymous function) www.dreamwidth.org:31
b.Widget._createWidget www.dreamwidth.org:31
b.(anonymous function).(anonymous function) www.dreamwidth.org:31
(anonymous function) www.dreamwidth.org:31
bG.extend.each www.dreamwidth.org:14
bG.fn.bG.each www.dreamwidth.org:14
b.fn.(anonymous function) www.dreamwidth.org:31
(anonymous function) www.dreamwidth.org:34
bG.event.dispatch www.dreamwidth.org:14
b6.handle.b4 www.dreamwidth.org:14

[fu]

Digging into it! Thanks, that's all very useful information.

One last thing: do you have beta testing for s2 comment pages on?

[shinbunshinobi]

Not a problem!

And nope. I don't. I only have the new JS and new create entries betas turned on.

[fu]

Got it, thanks! We'll have that fixed soon.

[shinbunshinobi]

No, thank you! You guys all do a fantastic job. =D

[misskat]

http://www.dreamwidth.org/support/see_request?id=21519 showed up. Turning off the JS beta fixed the issue. Only happening in Chrome for her. FF is fine.

[denise]

i'm not reproducing at all in chrome with beta on, so there's something obscure going on and we need more info.

[cloudsinvenice]

Hi, I've run into a problem crossposting in beta. Normally it works fine, but when I crossposted just now, the post didn't appear on LJ (though it did crosspost to Insanejournal fine). I went in to edit the DW post and found that the "crosspost to LJ" box was unchecked. I rechecked it and submitted the post again, and got the usual message saying it had requested to crosspost to LJ, but the post still didn't appear there. I've gone through this a few times, and it's always the same - when I go into "edit post" in DW, I find the box unchecked, recheck it, submit (and the box visibly stays checked), but the problem recurs.

I'm using Chrome Version 21.0.1180.90 (can't update it because I'm on OSX 5, but I've been crossposting merrily until today, so I doubt it's my aged browser).

[denise]

That means that the crosspost failed (check your inbox); LJ has been having problems crossposting lately.

[box_of_doom]

Perhaps I'm just not sure where to look, but I'm not sure how to/if it is possible to stop the crossposting of individual posts on the beta entries page? It just says that it will be, and gives me no way of deciding whether or not this will happen. (I can choose which DW account, but not uncheck my lj account if I don't want it crossposted to there.)

[denise]

Go to the "Settings" link in the upper right hand corner, check (or uncheck) whatever boxes you want and drag and drop them to wherever you'd like.

[avaragarda]

This is a little finicky request: in the original Post an Entry form, in HTML mode there's a checkbox to toggle "Disable Auto-Formatting" for the automatic <br> tags and such that get rendered when a post is published. This has been removed from the beta Create Entries page.

It's not a huge thing to have gone, but it does make it easier to give posts advanced styling if we have the option of turning that off (so that <td>s etc. can be visually separated a bit more instead of having a solid block of text to avoid extraneous linebreaks).

[denise]

It just hasn't been implemented yet. We're still looking for a good way to present it in the beta update page. In the meantime, you can disable auto-formatting around a portion of text by surrounding it in ... tags.

[avaragarda]

As in <...>unformatted

text here?</...>

[denise]

*facepalm* Sorry, that was me forgetting to escape. <raw-code> (text here) </raw-code>.

[wordweaverlynn]

I can't find a way to add an image to a new post.

Firefox 23.01
Mac OS 10.6.8

[denise]

A WYSIWYG-type editor hasn't been implemented yet in the new update page! Until then, you can use the HTML <img> tag.

[love_archived]

Hi! I'm sorry if this is unrelated to the current code push, since I only just noticed: the journal entry compose page now has customizable panels, which is nifty, but the panels don't act the way I expect them to when I click checkboxes. They aren't persistent (I keep unchecking Currents, why does it keep coming back? Whereas I keep re-checking Comments and they keep disappearing!)

[denise]

That sounds as though your preferences aren't being saved! When you customize your options on the beta customize page, are you certain to hit the "Save" button?

[love_archived]

Yup! The first time it happened, I thought, "Oh, duh, save button." But even though I made sure to do that afterwards, I keep getting checkboxes that uncheck/check by themselves! I made changes, hit Save, and then realized I'd forgotten X box, and when I clicked Settings again, the checkboxes were in the old pattern (I always notice Currents and Comments, because I _DON'T_ want Currents, and want Comments.)

If it helps, I'm on Windows 7, and in this iteration I'm using IE 10.0.9. (Two accounts, different browsers. The other account still uses the old compose style because I found the beta aggravating a LONG time ago when the beta was new.)