fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
fu ([personal profile] fu) wrote in [site community profile] dw_beta2012-09-23 11:54 am

Comment Pages in S2: the old becomes new

One of our long-running projects is to remove the old crufty code written in BML (our old templating system) and replace it with better alternatives throughout the site. And the coding for talkread.bml -- which is what is used any time you load up a site-skinned comment page -- is a particularly painful example.

Add to that, having the site-skinned comment pages be written one way, and custom comment pages another, makes it likely for one to lag behind the other. For example: site-skinned comment pages show the link for entries with screened comments as: "x visible | y screened". But S2 comment pages didn't have that information until this code push!

So I'm really happy to say that we have a new version of the comments page which uses pure S2, so now site-skinned comment pages and journal-styled comment pages are formed the same way on the backend even if they don't look the same. [personal profile] exor674 worked hard on the backend to make this possible, then [personal profile] momijizukamori came through with some spit and polish (with some help from [personal profile] kunzite).

The idea is for the new version to look as much as possible like the old version, though there might be a few discrepancies, because the backend is so different. [personal profile] momijizukamori has done her best to mimic the look and feel of the old comment pages. But the comments page is one of the most used pages here, so we'd like you all to come and give it a good shakedown.

Turn on beta testing for the "New S2 Comment Pages" -- and let us know in comments if you find anything out of the ordinary.

List of known issues.

momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

KNOWN/FIXED ISSUES

[personal profile] momijizukamori 2012-09-23 04:41 am (UTC)(link)
Collecting these here for everyone's edification :) Please reply to the main post with issues, not to this comment. Otherwise I can't edit and keep it updated!

Known



  • Comment subject has too much padding in Lynx/style=light
  • Filter/restriction symbols printing in a less-visible location
  • Time not displaying in 24-hour UTC format
  • QR box is appearing centered on page instead of under the comment it's in reply to
  • Very deeply nested threads may not be printing as links properly (core2 issue)
  • JS beta icon browser is taking the Tropo colors instead of the selected site scheme colors


Fixed



  • Comment header color is working off post order, not depth
  • Small gap below icons in comment headers - thanks [personal profile] chagrined for the fix!
  • There is no space between comment body and edit time, when a comment is edited - workaround, may need to be fixed in core2
  • Celerity is adding a border to .entry .header
  • Collapsed comments have a bolded subject link
  • Comment subjects are now links
  • ?style=light strips page styling along with all other styling
  • Entry title is now h3 instead of h2
  • div nesting within threads doesn't play nicely with CSS precedence
  • Seperator before 'Expand All' appears inside parentheses
Edited 2012-11-14 02:48 (UTC)
ahappylie: (Thinking)

comment title link feedback

[personal profile] ahappylie 2012-09-23 04:43 am (UTC)(link)
Just a visual tic of mine, but having three ways to link to a single comment seems a bit redundant to me. The comment title turning into a link changes the visuals of the site in a detrimental way to me, what with the extra underline on the title doubling up against the journal name and its underline and the overabundance of red in the header. Leaving the header as is with a black non-linkable title and the (Link) seems fine to me.

I've heard this is an issue with the S2 system that the developers weren't sure if they wanted to keep in, so I understand the reasoning, but that's my two cents on it so far.
musyc: Silver flute resting diagonally across sheet music (Default)

Re: comment title link feedback

[personal profile] musyc 2012-09-23 04:57 am (UTC)(link)
Seconding this. Leaving the subject headers as they were is preferable. Making them clickable links is very distracting in site scheme (Tropo Purple, here).
momijizukamori: Rufus Shinra from Final Fantasy 7 - hubric incarnate. (Rufus | hubris)

Re: comment title link feedback

[personal profile] momijizukamori 2012-09-24 07:12 pm (UTC)(link)
They've now been changed back to plain text!
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: comment title link feedback

[personal profile] chagrined 2012-09-23 05:02 am (UTC)(link)
I also really dislike the anchor-text-colored and underlined subjects on comments. I don't mind the fact that they link to the comment? But wish they'd lose the underline and revert to the regular non-link-text color. (For example, a lot of DW journal styles do that same thing for entry subjects. They are links to the entry, but they don't have the underline and they're the same color as the regular text, not the links.) (eta: this is when viewing with ?style=site, and I'm using tropo red)
Edited 2012-09-23 05:03 (UTC)
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-09-23 05:04 am (UTC)(link)
Oh, that's a method I hadn't thought of! Though it's generally not great practice to have a link indistinguishable from text...

But I'll definitely keep it on the table *g*
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

[personal profile] chagrined 2012-09-23 05:12 am (UTC)(link)
DW does already do it all over the site in a lot of their journal styles, though? But if you mean like, in the case of it being the site style, I see the point. (If it's changed to the new way, for myself I'd prolly just write a stylish script to make them look how I want and all.)

(Some other things I noticed I'm gonna put in a new comment now, heh.)
momijizukamori: (dreamsheep | styles)

[personal profile] momijizukamori 2012-09-23 05:14 am (UTC)(link)
A lot of them distinguish on hover (ie, change color or the underline appears), though yeah, a few don't. And yeah, not so great to have it on site scheme - but as I said, it's definitely an option for us to consider :)
marahmarie: my initials (MM) (Carlos Estevez)

Sure...

[personal profile] marahmarie 2012-09-23 06:46 am (UTC)(link)
No linkies: http://i.imgur.com/CZs98.jpg

Beta testing on: http://i.imgur.com/TN8k6.jpg

With this I can officially crown myself the queen of online errors. It never stops!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Sure...

[personal profile] momijizukamori 2012-09-23 06:53 am (UTC)(link)
Hmm. It actually looks like you're not getting the beta style at all - you don't have any of the differences others have reported. If you look at the source, is it a huge table, or stacked divs for the comments?
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Sure...

[personal profile] chagrined 2012-09-23 10:34 am (UTC)(link)
I had to throw ?style=site on mine for it to show up. Even w/ beta feature on and viewing this entry which uses site style for comments, I got the old style otherwise. But I figured that was intentionally for testing or whatnot.
montuos: cartoon portrait of myself (Default)

Re: Sure...

[personal profile] montuos 2012-09-23 01:12 pm (UTC)(link)
Ditto here; no evidence of beta style after turning it on. Source shows divs, not table. Tried clearing cache, turning off all Greasemonkey scripts, signing out and in again, restarting browser; nothing worked but [personal profile] chagrined's suggestion of ?style=site. Tropo Red, Nouveau Oleanders, Firefox 15.0.1, Kubuntu 12.04. Edit: Also not seeing it in Chrome 21.0.1180.89.
Edited 2012-09-23 13:16 (UTC)
marahmarie: my initials (MM) (Default)

Re: Sure...

[personal profile] marahmarie 2012-09-24 01:40 am (UTC)(link)
Fu dropped a comment below saying she fixed it (there was an error apparently that as usual, *sigh* affected me). Thanks for looking into it, though. :)
marahmarie: my initials (MM) (Default)

Re: Sure...

[personal profile] marahmarie 2012-09-24 01:39 am (UTC)(link)
Fu, love you, thanks so much! :)
momijizukamori: Jyuushirou Ukitake from Bleach, grinning happily (Ukitake | niko niko)

Re: comment title link feedback

[personal profile] momijizukamori 2012-09-24 07:14 pm (UTC)(link)
Fu worked out a version of the code she was happier with, so thankfully no need to resort to CSS hacking - they're now straight-up plain text~
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: comment title link feedback

[personal profile] chagrined 2012-09-24 07:16 pm (UTC)(link)
I saw when I came to reply to your other comments! :D Cool, glad it worked out. They work a lot more easily for my eyes now again, heh.
asklepios: ᴀᴄᴛʀᴇss ɴᴀᴛᴀʟɪᴇ ᴅᴏʀᴍᴇʀ; ʙʟᴏɴᴅᴇ (Default)

[personal profile] asklepios 2012-09-23 11:04 pm (UTC)(link)
+1 to this entire comment - the extra link doesn't actually serve any purpose except to put something in the way where I might accidentally click on it while trying to do something else to the comment. There are already two clearly marked ways of linking to the comment there, I'm not sure why anyone would want a third that doesn't add anything useful?
momijizukamori: (dreamsheep | styles)

[personal profile] momijizukamori 2012-09-24 07:02 pm (UTC)(link)
In most S2 styles, they were being used to build the page summary - which isn't a part of this style, and the 'thread' link only appears if a comment has replies. But subject lines are now unlinked, leaving just the small one in the header :)
yrbirdcanscene: blonde in a coat from a dior ad (dior coat)

[personal profile] yrbirdcanscene 2012-09-23 11:23 pm (UTC)(link)
I have to agree with all of this. I've tried it in Chrome, Firefox, and RockMelt, both with my Grease/Tamper Monkey and Stylish scripts on and off, and I find the linked titles to be ugly, quite frankly. The link is redundant, as there are multiple ways to access a comment link already.

Additionally, I like to comment from my smartphone, and don't like the mobile interface (which is neither here nor there), so I use the regular site, as it displays just fine. But with the comment titles made links, that's just one more thing I can accidentally click on while I'm just trying to scroll through the page.

Essentially, I don't think there was anything wrong with the previous comment title format (i.e. non-linked), and would be thrilled if it did not change.
boomvox: (pic#2886153)

[personal profile] boomvox 2012-09-23 11:29 pm (UTC)(link)
+1 to all of this, especially the mobile issue which I didn't even think of at first. I use the normal page through my smartphone's browser too, which is actually a lot easier than the mobile interface and just fine. But links in comment subjects are going to make scrolling and trying to click on anything else a real crap shoot.
momijizukamori: Young Vergil from the Devil May Cry doujinshi Bless. The text reads 'Turn you into stars' (kid!Vergil | turn you into stars)

[personal profile] momijizukamori 2012-09-24 07:16 pm (UTC)(link)
They've been changed! And thankfully the mobile interface should be getting a redesign to haul it into the 21st century soon (though that's not my project)
boomvox: (pic#3208725)

[personal profile] boomvox 2012-09-24 07:37 pm (UTC)(link)
Hooray to both of those things!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Science! | I do believe in phosphorylati)

[personal profile] momijizukamori 2012-09-24 07:08 pm (UTC)(link)
It's actually not a change from S2 - all journal styles have linked comment titles - but based on feedback we went ahead and changed it to mimic the BML style, so you should have happily unlinked comments now :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: comment title link feedback

[personal profile] momijizukamori 2012-09-24 07:00 pm (UTC)(link)
Ask and ye shall recieve ;) They're now unlinked.
ahappylie: (Fangirly)

Re: comment title link feedback

[personal profile] ahappylie 2012-09-26 09:49 am (UTC)(link)
You guys are awesome. ;A;
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 05:18 am (UTC)(link)
I made a picture of this for reference but it's large so I'm linking rather than embedding: http://i49.tinypic.com/2e49fv6.jpg

1) There is a small gap under the userpic btwn it and the bottom edge of the div it's contained within. Prolly a margin or padding that needs fixing.

2) The color-meaning scheme in relation to comment hierarchy has changed. Old style has top level comment subjectbars (whatever they're called) one color, and then next-level comments are another color, and I believe comment color swaps off like that based on the level of hierarchy. In the S2 style, color instead swaps off with each comment, regardless of hierarchy level. This makes the hierarchy levels more difficult to distinguish.

3) Old-style there is a gap btwn the bottom of the comment text and the "last edited" notice, if the comment was edited. New style there is not a gap. Prolly again an easy fix with margin/padding or w/e.

I'll comment if I notice anything else. :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 05:26 am (UTC)(link)
1) It's not actually padding or margin - I have yet to figure out /what/ it is, or how to fix it other than making the comment header fixed-height (really really really bad if an image doesn't load and prints it's alt text instead)

2) I literally noticed that when I edited that comment. EMBARASSING.

3) Ooh, nice catch! And now that I look, fairly easy to fix :) I guess the BML page was calculating the .odd or .even class off of depth, while S2 .comment-wrapper does it off of print order. But! We have an option for doing it by depth, too.
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 05:47 am (UTC)(link)
Figured out the gap. The img element for the userpic needs to be set to display:block;
momijizukamori: An extremely excited super-deformed Dante from Devil May Cry 3. The text reads 'Booya!' (Dante | booya!)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 06:03 am (UTC)(link)
/makes a note of this

Thank you!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 10:44 pm (UTC)(link)
All three now fixed :)
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 10:58 pm (UTC)(link)
Oops, now the hierarchy has the top comments all dark and all subsequent comments light? Even when they are replies to other sub-levels of the hierarchy. ;)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 11:04 pm (UTC)(link)
Oooh. Looks like the nesting order plays merry hell with CSS precedence. I'll have to dig in deeper to find a fix.
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 11:12 pm (UTC)(link)
I think it's .comment-depth-even and .comment-depth-odd you want? Looking at these comments, they already have those classes on them which seem to correctly correspond to the level of hierarchy. Unless I'm missing something else. :3
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 11:15 pm (UTC)(link)
That's what I'm using :) But it looks like if you go an extra level down, because .header is within both .comment-depth-even and .comment-depth-odd, both selectors try to apply, and .comment-depth-even wins (I suspect because of it's order in the CSS file)
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 11:29 pm (UTC)(link)
ahhh yes it would do that. well there is a solution to that. :)

I should go and look at some of the themed S2 comment styles b/c I think they use similar classes and get this right. and I don't think it does it in as ugly a fashion as I'm about to suggest, haha, which is that you could use selectors to define the chain of child divs so that it would only effect the .header divs that were {a certain level of child} from their many-levels-parent

like

hmmm apparently it looks like there's also a slightly lower-level-div that has .comment-wrapper-even (or odd) which is ...the opposite of what is on the parent for .comment-depth??? bizarre. um but yes you could do something like,

.comment-wrapper-even > .comment > .inner > .header

using the > selector to specify a direct child rather than any descendent. and the same for .comment-wrapper-odd. not super attractive when written out but gets the job done?

PLUS: okay I went and looked at the themed S2 comment style I use, in any case, and it actually colors the whole comment so acts directly on either .comment-wrapper- or .comment-depth- and thus doesn't have to do this. but yes. I think this would work anyway, for how you're trying to make the comments look here, without adding additional classes. (although it may make sense to just add an additional class? .comment-header-even and .comment-header-odd?)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 11:35 pm (UTC)(link)
Yeah, I think the nicest way may be to go into core2 and add the thread depth info straight into the comment-wrapper div - that way it's easily available to S2 styles who want the site-style heirarchy instead of the other methods.

And comment wrapper even and odd are like... the overall structure of the page. Like, if you were to view all comments just in order of when they were posted, no threading, the first comment is odd, the second is even, the third is odd, etc. It's what the first CSS version was working off of, which is why you were seeing that swapping regardless of depth.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 11:37 pm (UTC)(link)
Also, thank you very very much for being willing to poke at things and offer solutions - it means a lot to me :)
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-23 11:46 pm (UTC)(link)
oops yeah you are totally right, whoops. I was looking at this thread so they just happened to correspond, haha, b/c we were the only two commenting in it. so, okay, then instead you could do:

.comment-depth-even > .dwexpcomment > .comment-wrapper > .comment > .inner > .header

and same for odd. but I agree, adding another class lower down for thread depth info would be much nicer and prettier all around. :)

and no prob, I have enjoyed poking around! :) I've been trying once again recently to get started in dw_dev anywho so this is more fun related stuff, ha. (though I forgot to log into the alternate account I'm using for that for these comments, oh well.)
momijizukamori: (dreamsheep | styles)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-23 11:48 pm (UTC)(link)
Ooh, do join us ;) I mostly work in styles, which is very easy to start out in if you know CSS - I think aside from typo fixes, adding new color themes is one of the easiest starter patches.
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-24 12:01 am (UTC)(link)
I did like one patch back in december and then just had a lot of other things happen in life which prevented me from doing more. actually I should have commented on this entry with [personal profile] kimira which is the alt account I am using now for dw_dev stuff, but I 4got and commented with my regular account instead, oops.

maybe I will try some styles things! in december I was working on / now am trying to again work on this bug, which is sort of also S2 related? but my dream is a fix for the bug to allow video embedding in comments, haha, which will probably require beefing up my perl skills ...a lottttt. XD
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-24 12:03 am (UTC)(link)
Whooo removing tables! I fully approve (as uh probably noted by the fact that I wrote most of this S2 comment page stuff in like a week).
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-24 06:57 pm (UTC)(link)
Fu suggested a slightly more compact version of CSS, which we ended up using - it turned out to be simpler that way than trying to integrate depth counting into core2

(if you're curious, it's .comment-depth-even >.dwexpcomment .header)
chagrined: Marvel comics: zombie!Spider-Man, holding playing cards, saying "Brains?" (brains?)

Re: Some other differences I noticed in the site comment scheme

[personal profile] chagrined 2012-09-24 07:04 pm (UTC)(link)
ohhhh yes, that makes total sense! :D thx for sharing with me. a very wise fu.
momijizukamori: Jyuushirou Ukitake from Bleach, grinning happily (Ukitake | niko niko)

Re: Some other differences I noticed in the site comment scheme

[personal profile] momijizukamori 2012-09-24 07:05 pm (UTC)(link)
She is indeed :D
highlander_ii: 3 images of Hugh Jackman in a black suit ([Hugh] 3 Hughs)

[personal profile] highlander_ii 2012-09-23 05:27 am (UTC)(link)
in beta:

post is this: http://highlander-ii.dreamwidth.org/554588.html

click the comment link, you get this: http://highlander-ii.dreamwidth.org/554588.html?nc=3#comments

-- the 'action' icons across the top are missing
-- the post 'content' is hidden (this may be desired behavior, but not one that I've seen in the past
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:31 am (UTC)(link)
Hmm, can you screencap for me? I'm still seeing the post and interaction links if I scroll back up from where the '# comment' redirects you.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:45 am (UTC)(link)
Hmmmm. Are you using any Greasemonkey scripts? That's... really weird.
highlander_ii: Tony giving peace sign w/ text *peace* ([Iron Man] *peace*)

[personal profile] highlander_ii 2012-09-23 05:46 am (UTC)(link)
just the DW post expand/collapse one... which could be doing it, as, both of those posts had been collapsed.

... and the expand/collapse icons are on that page and they work... so, that's probably it.... (just tested that)
Edited 2012-09-23 05:47 (UTC)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:48 am (UTC)(link)
Hm. Can you turn it off and test or look in another browser?
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:49 am (UTC)(link)
Aha! Okay :) Yeah, the Greasemonkey script must be looking for something in the CSS, and refreshes on page-load
highlander_ii: Josh Duhamel's hip; his hand in his pocket ([Josh D] hand inna pocket)

[personal profile] highlander_ii 2012-09-23 05:50 am (UTC)(link)
probably so... Chrome didn't do that (doesn't have that extension)...

momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 05:56 am (UTC)(link)
Okay, sounds like a Greasemonkey problem then, unfortunately :\ Might be worth reporting to the script author?
marahmarie: my initials (MM) (Default)

[personal profile] marahmarie 2012-09-23 06:10 am (UTC)(link)
Titles aren't linkifying for me in site scheme with comment beta turned on. They're supposed to, right? (using tropo red, btw)
Edited (info) 2012-09-23 06:11 (UTC)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 06:15 am (UTC)(link)
They should! Can you give me a screencap? (I'm also using Tropo Red and seeing them linked)
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2012-09-23 11:58 am (UTC)(link)
Same here with Tropo Purple and in both Chromium and Iceweasel.

Beta is turned on and the divs are there instead of the tables.

EDIT: Or should there be no tables at all? Maybe I am not getting the S2 pages after all...

More EDIT: like the one persona above, with style=site I get the new style, but without, I am seeing the old one.

http://imgur.com/DV8XD

Edited 2012-09-23 12:01 (UTC)
turlough: green origami Stegosaurus ((other) not a cuddly toy)

[personal profile] turlough 2012-09-23 05:20 pm (UTC)(link)
I tried the new comment pages for the light style and they're looking quite awful as you can see here and here.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 08:37 pm (UTC)(link)
Oooh. Looks like ?style=light strips out the page styling CSS along with everything else (and probably 3/4s of the new icon page 'look' is in the CSS). Most definitely noted!
turlough: a white tea cup on breen with the text 'a cup of tea makes everything better' in white ((other) tea)

[personal profile] turlough 2012-09-23 09:11 pm (UTC)(link)
That's what I suspected had happened. I only use it on comment pages, but since you can use it as a site scheme I guess the new icon page not looking completely borked in it would be rather important.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 09:17 pm (UTC)(link)
Yeah, though the Lynx site scheme doesn't have the same problems - that one I tested. Throwing ?style=light does some extra stripping, I think, and it's taking out the base page styling along with everything else.

...also that should have said 'comment page' instead of 'icon page' there, but it's true of the icon page too *g*
turlough: deckchairs on Brighton Beach, June 2013 ((mcr) tell me I'm an angel)

[personal profile] turlough 2012-09-23 09:51 pm (UTC)(link)
Interesting. I've always thought they behaved the same. I mean, they look the same. Or at least they did a couple of years ago when I was thinking of changing my default to Lynx. I haven't looked at it since then though.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 09:53 pm (UTC)(link)
Yeah, they should look the same? But I know Lynx set to default doesn't do the stripping, because I tested the new page in it. Hopefully Fu will have a better idea what's going on :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 06:58 pm (UTC)(link)
We've got ?style=light and Lynx working properly with the new pages now! (turns out it was totally stripping the default stylesheets)
turlough: Gabe Saporta doing thumbs-up ((cs) gabe approves)

[personal profile] turlough 2012-09-24 07:14 pm (UTC)(link)
Looks good now!
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-09-24 07:18 pm (UTC)(link)
Appropriate icon is appropriate *g*
turlough: on the bridge of the Swinetrek, Pigs in Space on The Muppet Show ((muppets) pigs in spaaace!)

[personal profile] turlough 2012-09-24 07:47 pm (UTC)(link)
Btw, in .comment-info I would suggest letting .poster display inline instead of block. That way you get rid of the irritating strip of grey under the icon and the datetime + permalink + management-links combo moves up beside .poster instead of being squished under it. (Looks like this now and with the suggested change like this.)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 07:51 pm (UTC)(link)
The problem there is actually that Lynx doesn't strip the massive amount of padding that header tags have on them :\ It's certainly a possibility, but it's more a departure from the BML look, and I'm afraid it'll cause messy-looking line-breaks sooner (as that line is now longer)
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2012-09-24 07:53 pm (UTC)(link)
It is ok to recode the Lynx site skin. I believe it was written in 1998. :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 07:54 pm (UTC)(link)
Ahh, I might add that reset to it then :)

(and omg ANCIENT CODE)
turlough: snickering Duchess, Disney's 'Aristocats' ((disney) fun)

[personal profile] turlough 2012-09-24 08:00 pm (UTC)(link)
That just means it's a classic :-)
momijizukamori: (dreamsheep | styles)

[personal profile] momijizukamori 2012-09-24 08:02 pm (UTC)(link)
Lynx = the hipster userscheme? All 20th century up in here ;)?
turlough: Jamie McCrimmon & the Doctor & Victoria Waterfield in a rubber dinghy, Second Doctor adventure 'Fury From the Deep' ((dr who) companions)

[personal profile] turlough 2012-09-24 07:59 pm (UTC)(link)
Silly Lynx!
boomvox: (pic#2863491)

[personal profile] boomvox 2012-09-23 07:32 pm (UTC)(link)
I'm turning it on and off as I mess with it overlaid with a greasemonkey script (turned off for now to look at this), and I've noticed that when comments are collapsed, all the links to the collapsed comments are bolded, when they aren't without the beta turned on.

I'd also like to echo that the bold/underline link on subject lines is aesthetically unpleasing and distracting. It makes me think there's a borked tag in the post body I need to go fix, and it looks really clunky.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 09:20 pm (UTC)(link)
The collapsed comment thing is noted! I'll get that added to my list :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 10:45 pm (UTC)(link)
Collapsed comments should now be fixed!
boomvox: (pic#3208725)

[personal profile] boomvox 2012-09-23 10:52 pm (UTC)(link)
Yep, looks fixed from here! :)
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-09-23 11:37 pm (UTC)(link)
Oh, thank you for that. It was very distracting to have those bolded. Much, much nicer now.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 11:40 pm (UTC)(link)
All hail the power of git, which lets us roll fixes to live quickly *g*
cmshaw: Fullmetal Alchemist: Winry repairs Ed's arm (Mechanic)

[personal profile] cmshaw 2012-09-23 07:52 pm (UTC)(link)
In Celerity, the entry title has shrunk from h2 to h3 and there's now a line between the poster info and the action box. The title change isn't a huge problem (although I do like it larger) but the line is a bit disorienting. If there's a dividing line wanted, it would make much more sense to me to have it instead between the actions and the title + content, but I'm not sure why it's wanted.

(Chrome on Vista; I can screenshot if this is an error instead of a choice!)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 08:44 pm (UTC)(link)
Can you screencap the line for me? And I'll make a not of the font-size thing and check it across the other site schemes - that one is an easy enough fix :)
cmshaw: Fullmetal Alchemist: Winry repairs Ed's arm (Mechanic)

[personal profile] cmshaw 2012-09-23 09:10 pm (UTC)(link)
Here is it:

http://ic.pics.livejournal.com/cmshaw/392463/199772/199772_original.png

Thanks! :)
Edited (augh, that image is huge, changing to a link) 2012-09-23 21:11 (UTC)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 09:18 pm (UTC)(link)
Ooh, naughty Celerity, adding an extra border in there. I'll get that taken care of.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-23 10:45 pm (UTC)(link)
Got the problems with Celerity fixed :)
cmshaw: Fullmetal Alchemist: Winry repairs Ed's arm (Mechanic)

[personal profile] cmshaw 2012-09-24 02:56 am (UTC)(link)
\o/ This is an awesome project, by the way. :)
momijizukamori: (dreamsheep | styles)

[personal profile] momijizukamori 2012-09-24 06:54 pm (UTC)(link)
font-size on titles should be what it used to be now!
marahmarie: my initials (MM) (Default)

Never mind...

[personal profile] marahmarie 2012-09-24 02:03 am (UTC)(link)
For some reason this comment: http://dw-beta.dreamwidth.org/13187.html?thread=290179#cmt290179, which began the entire thread about Comment Beta not working at all, is marked 5a. and is many comment threads *below* the replies from fu and momijizukamori to it. Their replies (and my subsequent replies) are under 2b1a-2b1a1a2a, a thread that was about another issue entirely, here: http://dw-beta.dreamwidth.org/13187.html?thread=286083#cmt286083! As soon as I find a screen cap program that can scroll the entire page without freezing up (the one I have now doesn't cut it) I'll edit to add a screencap of this.

I'm thinking that turning on both ECHI and Comment Beta has borked the threading up? Actually (edit) the threading is the same logged in or logged out; just noticed. I'm not going to post a screencap after all; looking at it more, this one might be on me (that somehow I replied to the wrong thread). I don't have email copies of my own replies to trace this back with (I discard those as soon as I get them, which is why my replies hit almost everyone's Spam folders) so never mind...
Edited (eh) 2012-09-24 02:19 (UTC)
cmshaw: Fullmetal Alchemist: Winry repairs Ed's arm (Mechanic)

[personal profile] cmshaw 2012-09-24 02:53 am (UTC)(link)
Okay, here's a weird one: the comment-handling links in the beta scheme now have extra (and incorrectly placed) dividers.

Old style:
(66 comments) - (Post a new comment)
(Flat) (Top-level comments only) (Expand All)

Beta style:
66 comments Post a new comment
Flat | Top-Level Comments Only | Expand All

--okay, hey, that's really weird. There are parentheses around each of those links that are not being copied in the text. It must be a weird style thing...? This is still in Celerity. Hang on, let me get another screenshot:
http://ic.pics.livejournal.com/cmshaw/392463/200187/200187_original.png
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 04:20 am (UTC)(link)
Yeah, the seperator difference is Known, and it was decide that it wasn't a significant enough change to be worth the effort necessary to fix it (unless a pile of people complain *g*)

The parentheses not copying is a weird thing with how :before and :after elements are displayed, so not just you! Just weird CSS behaviour.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 04:38 am (UTC)(link)
and whoops, Fu pointed out that I missed the misplaced | in Expand All. That is /not/ intentional, and will be added to my list of issues :)
cmshaw: Fullmetal Alchemist: Winry repairs Ed's arm (Mechanic)

[personal profile] cmshaw 2012-09-24 01:21 pm (UTC)(link)
Thanks! :)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 06:53 pm (UTC)(link)
And we've got that fixed now, too :)
zvi: self-portrait: short, fat, black dyke in bunny slippers (Default)

[personal profile] zvi 2012-09-24 03:15 am (UTC)(link)
When I'm viewing entries in light style, the entry management links have little black dots on them. I think it's the list icons from an unordered list.

Also, the comment interaction links are lined up vertically, instead of horizontally.

I have light style by default when viewing entries.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 04:22 am (UTC)(link)
Yeah, ?style=light is currently stripping the stylesheets the S2 styles call on their pages (so the /icons page looks a little weird too, because it's not getting CSS styling either)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 06:52 pm (UTC)(link)
?style=light should now be working properly with the new pages!
turlough: Frank Iero asking a question, art by theopteryx ((mcr art) excuse me?)

[personal profile] turlough 2012-09-24 09:23 pm (UTC)(link)
I've just noticed another thing.

The filter and restriction symbols are now located between span.poster.entry-poster and span.datetime instead of the filter symbol above in #entrysubj (above the subject itself) and - which I discovered just now - the restriction symbol nowhere. The old position isn't ideal (and WHERE is the restriction symbol?) but at least it's visible. With the new coding I didn't even notice it was a locked entry for the longest time.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-24 11:33 pm (UTC)(link)
Iiiinteresting! I didn't catch that - it looks like it's using the default S2 printing for filter/restriction which yeah, with the set-up here is significantly less than ideal.

Would inline with the subject make the most sense, you think?
turlough: deckchairs on Brighton Beach, June 2013 ((disney) who are you gonna call)

[personal profile] turlough 2012-09-25 04:06 pm (UTC)(link)
That's definitely where I would put it myself.

I also noticed another odditiy today: I have 24-hour time enabled but the new s2 coding makes everything display in am/pm format. Most annoying for a European :-)

Oh yes, and in both Tropo Red and light style the CSS adds a very misleading UTC after the time - .entry .datetime:after{content:" UTC"} - which makes the am/pm look even weirder.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-25 07:51 pm (UTC)(link)
Hmm, I'll dig into the code behind that one. I think on my Hack it was using 24-hour time but... isn't here. On to the buglist it goes!
kate_nepveu: sleeping cat carved in brown wood (Default)

[personal profile] kate_nepveu 2012-09-25 07:23 pm (UTC)(link)
I was just coming here to ask for that. Yes please, inline with the subject. (I'm turning beta testing off for now, out of paranoia.)
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-09-25 01:24 pm (UTC)(link)
I can't figure out how to do screencaps or whatnot on my (ancient) iPodTouch, but the comment bar headers have really small text which is almost impossible to read without serious zooming. The little usericon greydude is also looking odd, with a HUGE shadow on its right side. (It's entirely possible this is just iThingie weirdness and nothing to do with/nothing fixable in the code changes, but figured it couldn't hurt to mention.)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-25 07:44 pm (UTC)(link)
Hmm. I will see about grabbing someone with an iDevice for testing!
marahmarie: my initials (MM) (Default)

Have beta s2 comment titles been de-linkified on purpose?

[personal profile] marahmarie 2012-09-26 01:10 am (UTC)(link)
Because once again: no linkies.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Have beta s2 comment titles been de-linkified on purpose?

[personal profile] momijizukamori 2012-09-26 01:11 am (UTC)(link)
Yes, they have - they were pretty much the #1 thing people wanted changed so far, so we went ahead and pushed a change for it :)
marahmarie: Drink coffee, do stupid faster (coffee)

Re: Have beta s2 comment titles been de-linkified on purpose?

[personal profile] marahmarie 2012-09-26 04:51 am (UTC)(link)
Just checking my view wasn't messed up again. Didn't think I would, but I honestly prefer it without comment title links on site scheme, too (but because I cannot stand the underlining, not because I don't want the links: I love links, I want everything to link). Make links, not war...
boomvox: (pic#2863490)

comment box centering?

[personal profile] boomvox 2012-09-26 05:47 pm (UTC)(link)
On Tropo schemes, when you hit "Reply to this" on a comment high enough in a thread to allow for the width of it, the comment box shows up centered (even sometimes off-center to the right) instead of aligned properly beneath the comment you're replying to. It's not noticeable on comments lower down in threads, which is why I don't think I noticed it before.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: comment box centering?

[personal profile] momijizukamori 2012-09-26 11:07 pm (UTC)(link)
Hmm. I will play with this! I know why it's happening, it's some code I put in because the comment box was being printed off-center if you hit the 'reply to entry' link - but I didn't catch it going all the way down.
trinity_clare: (Default)

[personal profile] trinity_clare 2012-09-26 07:51 pm (UTC)(link)
I was going to comment and say that threads weren't indenting right, but I refreshed and now they're fine!

Hmm. Mildly dislike the show/hide functionality. It's just too weird that they disappear completely instead of showing the collapsed version. Meanwhile, there's no more collapse button! Is this a change that's happening because of the new scheme, or did it happen earlier and I missed it? I would much rather collapse a thread than make it go away altogether. On the same theme, I'd love there to be an Expand button on top-level comments, even when the reply directly below it is already expanded. If I want to expand the whole gosh-darn thread, I want to expand the whoooooole gosh-darn thread, not one subthread at a time.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-26 11:18 pm (UTC)(link)
Hmmm. I will talk to the people doing that side of things - the problem is that the implementation isn't in S2 at all, not just this version of it (which is one of the things we're trying to get away from - having to update two sets of code in tandem)! Just for reference, are you using the new Javascript beta as well, or no?
trinity_clare: (Default)

[personal profile] trinity_clare 2012-09-27 12:11 am (UTC)(link)
Thanks for passing it along. I realize these are more complaints about the layout itself than display bugs, but I figured I'd add my 2c.

And yes, I do have the Javascript beta on.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-09-27 05:27 am (UTC)(link)
Eh, I'd argue loss of functionality is a bug :)
trinity_clare: (Default)

[personal profile] trinity_clare 2012-09-27 04:38 pm (UTC)(link)
I totally admit that I haven't been spending a lot of time on DW, so I probably just missed stuff like the "hide" button.

I don't use any scripts or extensions. Argh. Did the old LJ have a collapse button? Maybe I'm just hallucinating, in which case I should probably submit "collapse button" to suggestions.
goody_scrivener: (Fizgig)

Is cross-posting broken?

[personal profile] goody_scrivener 2012-09-27 07:10 pm (UTC)(link)
I just noticed that both of my new posts from today, as well as the several dozen archive posts I've copied into my DW from a WordPress blog, are NOT cross-posting to my LiveJournal account. The last post to cross-post is dated 9/23, so this is something fairly new.

I've tried editing those posts and manually re-checking the cross-post box, but no luck there. And that box is definitely checked when I start a new post.
Edited 2012-09-27 19:13 (UTC)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: Is cross-posting broken?

[personal profile] momijizukamori 2012-09-27 10:54 pm (UTC)(link)
Your best bet would be to open a Support request - nothing in this particular beta should have gone anywhere near crosspost settings, so I'm afraid I'm not much help!
cheyinka: A glowing blue sheep with green eyes (electric sheep)

interesting behavior in a page loaded before I enabled the beta

[personal profile] cheyinka 2012-09-28 08:49 pm (UTC)(link)
This isn't, strictly, a bug, but it was kind of interesting:
Using Celerity as my site skin:
I loaded the most recent dw-news entry, started reading, enabled the beta, and then resumed reading. When I got to the comments, I discovered that expanding a thread resulted in that thread not being indented anymore. Reloading fixed it, so it's in the "neat glitch" category, not the "annoying bug" category for me, but I thought I'd share it just in case!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: interesting behavior in a page loaded before I enabled the beta

[personal profile] momijizukamori 2012-09-29 04:11 am (UTC)(link)
Hmmm. I bet it was trying to call the old BML version of comments and failing ;) Those use images for indentation (turn off images in your browser and you'll see what I mean on the old page - horrifying)
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: interesting behavior in a page loaded before I enabled the beta

[personal profile] cheyinka 2012-09-30 03:00 am (UTC)(link)
I spent a couple weeks where I was getting a wireless signal strength in the single digits, and discovered that at the time!

And yeah, I bet that's exactly what it was doing - it just was visually interesting, and I expect when this goes out of beta at least one person will get the same thing, from having a stale tab. :D
cheyinka: A glowing blue sheep with green eyes (electric sheep)

tracking comments

[personal profile] cheyinka 2012-10-05 10:18 pm (UTC)(link)
Fairly certain this is just Chrome being weird (possibly just Chrome in Windows, I can switch into FreeBSD and check), because it works fine in Firefox in Windows but:
Previously, I could middle-click the bell icon and go directly to the more-options page for tracking; now middle-clicking just causes the same popup as left-clicking.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

Re: tracking comments

[staff profile] denise 2012-10-05 10:28 pm (UTC)(link)
That usually means the browser's prevented the JS from loading -- are you having problems with the javascript site-wide? Check your security settings and make sure you haven't blocked scripting from us.
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-05 11:48 pm (UTC)(link)
I haven't blocked scripting, and I haven't noticed any other issues - answering a poll still works, for example. The more options link in the tracking popup works, too - it's just that middle-clicking the link doesn't open the more options page in a new tab the way it does in Firefox or the way it used to in Chrome.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

Re: tracking comments

[personal profile] momijizukamori 2012-10-07 06:37 am (UTC)(link)
It does sound like it may be Chrome weirdness, possibly with regard to keyboard/mouse short-cuts (as middle-click is just a shortcut to 'Open link in new tab'). Does right-click -> open link in new tab work?
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-07 05:55 pm (UTC)(link)
Yep, right-click then open link works fine!
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

Re: tracking comments

[personal profile] momijizukamori 2012-10-08 04:23 am (UTC)(link)
Yeah, in that case it sounds like Chrome changed something with how they register on-click events in Javascript :\
cheyinka: A glowing blue sheep with green eyes (electric sheep)

Re: tracking comments

[personal profile] cheyinka 2012-10-08 09:19 pm (UTC)(link)
It is just the new comment pages; new comment pages off with beta JS on still works, but new comment pages on with beta JS off doesn't work. (Well, it works except for this one tiny thing! Otherwise, the new pages look extremely similar and the one difference I notice is (in my opinion) an improvement.)

[Edit, 2012-10-10: Same behavior in Chrome (well, "chromium") in FreeBSD; still works in Firefox in FreeBSD.]
Edited (may as well just edit the comment) 2012-10-10 18:31 (UTC)
kimira: (Default)

possibly slightly off-topic? style=site on recent entries

[personal profile] kimira 2012-10-12 11:36 am (UTC)(link)
So, maybe it was already possible to do this and I just never noticed, but I just realized that anyway now that S2 pages are being used for comments, you can also throw ?style=site on a journal's recent entries to view them that way. Example: http://dw-news.dreamwidth.org/?style=site

I think that's pretty fabulous and a nice alternative to style=mine and format=light (much prettier than format=light), but it seems to have some bugs right now:
1) throw a clear:left on .entry-wrapper so the "Previous 20" at the top isn't pushing the icon & username over.
2) the memory/share/track links are showing up twice, both at the top of the entry in the center, and at the bottom in a line with the comment links. I like them at the bottom but I guess it'd work either way. If the ones at the top are kept, there's an extra border around .action-box ul that should probably be ditched.

Anywho, maybe this did already exist and I never knew about it. Maybe it's not connected to implementing S2 on comment pages and I should submit this to help/support to have it marked as a bug instead? I'd also be happy to throw up a patch for those CSS things if it is posted as a bug or something.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

Re: possibly slightly off-topic? style=site on recent entries

[staff profile] denise 2012-10-12 12:16 pm (UTC)(link)
Been there for a while! [personal profile] foxfirefey is working on it, I believe.
kimira: (Default)

Re: possibly slightly off-topic? style=site on recent entries

[personal profile] kimira 2012-10-12 12:21 pm (UTC)(link)
Ahh, cool, thanks. I couldn't find it in bugzilla anywhere (but it can be kind of hard to search for things there). It's looking quite nice so far!
moptothehead: (Default)

[personal profile] moptothehead 2012-10-21 05:45 am (UTC)(link)
Have all beta features turned on for this (paid) account. Seeing links in a long nested comment thread collapsing into text further down! Here are screenshots:

http://i.imgur.com/TwV14.png
http://i.imgur.com/5Whxs.png

(It's a private post, but it's currently at 262 comments, with 260 in the featured thread.)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-10-21 07:05 am (UTC)(link)
That.... is certainly an interesting bug. I'll have to see about replicating it to dig into the problem. If you have time, could you cycle through having only one beta feature turned on at a time, to see if it's a specific one causing vs a combo?
moptothehead: (how to top this time...)

[personal profile] moptothehead 2012-10-22 01:43 am (UTC)(link)
Only seems to happen with S2 Comment Pages turned on, regardless of other combinations.
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-10-22 04:56 am (UTC)(link)
Good to know! If you can do me a huge favor - can you set the journal it's in to use journal-styled comment pages (it's in account settings... um, somewhere) and tell me if it's still an issue there? Trying to figure out if it's a general S2 problem (ie, it affects S2 journal styles as well) or just something specific to the S2 site styles.
moptothehead: (that sounds kinky)

[personal profile] moptothehead 2012-10-22 06:50 am (UTC)(link)
No worries! Just did so, and it seems to eliminate the problem; the comments are back to links and there's no block of text. The style being used is Flexible Squares.

I can get a screenshot if you'd like.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-10-22 07:05 am (UTC)(link)
Oh, hmm. That wouldn't actually check for the bug - Flexible Squares (and all other LJ import layouts) are based on a different core layer than the DW official layouts, including site views. So they don't use the same code. I'll figure out a different way to poke at it *g*
momijizukamori: Grey tabby cat with paws on keyboard and mouse. The text reads 'code cat is on the job', lolcats-style (CODE CAT)

[personal profile] momijizukamori 2012-10-29 07:20 am (UTC)(link)
So, congratulations, you found a really weird bug in core2 XD It /does/ seem to be Firefox-specific (possibly only to newer versions, too, but I don't have an easy downgrade method to check), so swapping back to the old comment pages or a browser other than Firefox will get the comments to look fine. Fu and I are digging into the code, so this should be fixed by the next push :)
ruriair: (ɀәρɑɼ : uncertainty)

[personal profile] ruriair 2012-10-25 01:28 am (UTC)(link)
S2 comments beta seems to be causing a... weird issue. When reading [community profile] wankgate, all the comments appear bolded after this thread where, as you can see I asked, apparently someone put a bold HTML tag in their comment to allow a subject-only reply - at least that's what I think. It's affecting everything below it, as well as the post, reading page, inbox, etc. links in the site header.

When logged-out or when all beta testing is off, only the particular comment itself with the emoticon in its subject appears bolded. At the moment I don't know if it's because the anon didn't close their bold tag or what, having no reply.

... I only read that meme when I'm super bored and don't condone most of what goes down there. It's kind of like a trainwreck syndrome.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2012-10-25 01:36 am (UTC)(link)
Almost certainly an unclosed <b> tag, yeah. The old version of site-skinned comment pages are built with HTML that causes most browsers to auto-close any unclosed formatting tags; the S2 site-skinned comment pages are constructed with HTML that many browsers don't auto-close tags inside. So it'll be all up to the individual browser how it interprets an unclosed tag.

There's not much we can do to fix something like that -- our HTML cleaner does somewhat attempt to close unclosed tags, but it's not perfect -- so if it's really annoying people, the journal owner can delete or screen the comment to prevent the bold from overflowing. (Or, if you post a comment beneath it with an unmatched closing </b> tag, that might help.)
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-10-25 02:26 am (UTC)(link)
Hmmm that is good to know - I know the unclosed tag thing is fairly common in RP circles to get a blank comment (though I'd assume having a closing tag instead would keep it from happening, and you can do it with just the opening angle bracket because it's assumed to be HTML).

I will see about spreading the word on that one.
instantramen: a woman with black hair and white skin pouring water from a kettle (Default)

[personal profile] instantramen 2012-10-27 06:57 am (UTC)(link)
Something about the new beta comment pages is messing with the beta icon browser. I use Gradation Vertical for my site skin, and before I turned on the New S2 Comment Pages the beta icon browser appeared in dark colors matching the Gradation color scheme. When I turn the new comment pages on, it's suddenly colored to match the light site skins, but if I go back to old comment pages it's normal again.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-10-29 05:57 am (UTC)(link)
That is... interesting and unexpected! I'll conference with [personal profile] fu and see if we can figure that one out.
hermitsoul: online computer icon (* Online: unexpectedbox)

[personal profile] hermitsoul 2012-11-12 07:31 am (UTC)(link)
Very minor, but with the new version, page titles are 'username| subject' instead of 'username: subject'. Will this be permanent once the changes goes live?
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-11-12 11:04 pm (UTC)(link)
Most likely - the aesthetic change is minor enough that its not worth making the code base more complicated to change back.
hermitsoul: green socks icon (* green sock: hermitsoul)

[personal profile] hermitsoul 2012-11-12 11:41 pm (UTC)(link)
Thanks for letting me know - quite a few of us use scripts to help create fandom newsletters, and this change breaks all of mine. I guess I better start updating them!
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2012-11-12 11:43 pm (UTC)(link)
The good news is that we have quite a lot of useful things in development for newsletter assemblers, and eventually (sadly not soon soon, but eventually) you won't need your scripts at all. :)
hermitsoul: woman in corset icon (* corset: ravenclawbest)

[personal profile] hermitsoul 2012-11-12 11:48 pm (UTC)(link)
That's great to hear! Now, if I can just figure out an easy way to deal with LJ... :D
musyc: Moss from IT Crowd, captioned "then which country am I speaking to?" (IT Crowd: Which country)

[personal profile] musyc 2012-12-01 05:31 am (UTC)(link)
I'm picking up an interesting and random quirk with the new comment pages.

Screencap! - All DW betas are on; all userscripts and etc were off.

It's appearing on both Firefox 3.incrediblyold.butpryaddon.fromcolddeadhands and Firefox 17.wants.updatesevery.freakingnightwtf, about once every couple of weeks, but I cannot even begin to guess what is causing it.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-12-03 12:29 am (UTC)(link)
Hmmm. Is this all threads, or just some, and do you have a different browser on your computer you can check on? (I'm not getting it, so investigation is required *g*)
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-12-03 04:08 am (UTC)(link)
Just some, and it's totally at random, afaict. I do have a couple of other browsers to choose from. I'll try to track/note circumstances when it happens again, to narrow down the possibilities.
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2012-12-03 05:10 am (UTC)(link)
If you could! Subject lines and the alt/title text for icons would be one place to look for problems.

Page 1 of 2

<< [1] [2] >>